Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): use the go-spdk-helper with the new delta map APIs #238

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(deps): use the go-spdk-helper with the new delta map APIs #238

wants to merge 1 commit into from
+1,156 −185

Conversation

DamiaSan
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#9766

What this PR does / why we need it:

Inside go-spdk-helper, the function BdevRaidCreate now has some additional parameters, for example to enable delta map and superblock, so we must align to that.
What about SPDK, Dockerfile has been updated to point to the delta map implementation in the new longhorn-v24.09 branch, which contains some fix respect to the one in longhorn-v24.05 branch.

Special notes for your reviewer:

Additional documentation or context

@DamiaSan DamiaSan requested review from innobead, derekbit, shuo-wu and a team November 14, 2024 10:49
@DamiaSan DamiaSan mentioned this pull request Nov 14, 2024
Closed
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 14, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@DamiaSan DamiaSan mentioned this pull request Nov 15, 2024
Merged
@derekbit
Copy link
Member

Move the commit [deps: update Dockerfile to SPDK longhorn-v24.09 branch](https://github.com/longhorn/longhorn-spdk-engine/pull/238/commits/f036a4f177cbc421230475f0badd256bc380a5ec) to a new PR.

@DamiaSan
fix(deps): update go-spdk-helper for delta map
9dcd400 
The version of go-spdk-helper with the new delta map APIs contains
the function BdevRaidCreate with additional parameters.

Longhorn 9766

Signed-off-by: Damiano Cipriani <[email protected]>
@mergify Mergify
Copy link

mergify bot commented Nov 17, 2024

This pull request is now in conflict. Could you fix it @DamiaSan? 🙏

@DamiaSan DamiaSan changed the title Use the go-spdk-helper with the new delta map APIs fix(deps): use the go-spdk-helper with the new delta map APIs Nov 19, 2024
@derekbit
Copy link
Member

@DamiaSan is the PR ready?

@DamiaSan
Copy link
Contributor Author

@DamiaSan is the PR ready?

No, it is waiting for longhorn/go-spdk-helper#163 to be approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead Awaiting requested review from innobead

@derekbit derekbit Awaiting requested review from derekbit

@shuo-wu shuo-wu Awaiting requested review from shuo-wu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DamiaSan @derekbit